Skip to content

Commit

Permalink
[ci] Regenerate Rubocop todo file
Browse files Browse the repository at this point in the history
`Rails/SkipsModelValidations` is excluded for all jobs. As now the code
to run the job manually is in a rake task, Rubocop complains, so
we need to exclude it as well.

There is a Rubocop bug, that's why I needed to modify the Rubocop
configuration as well.
  • Loading branch information
Ana06 committed Dec 8, 2017
1 parent 668724d commit fe1198a
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 19 deletions.
8 changes: 0 additions & 8 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,3 @@ Rails/Output:
- 'src/api/config/*'
- 'src/api/db/**/*'
- 'src/api/lib/**/*'

# Checks for the use of methods which skip validations.
Rails/SkipsModelValidations:
Exclude:
- 'src/api/db/migrate/*'
- 'src/api/app/jobs/*'
- 'src/api/spec/models/bs_request_action_spec.rb'
- 'src/api/spec/models/review_spec.rb'
34 changes: 23 additions & 11 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-12-04 09:56:31 +0000 using RuboCop version 0.51.0.
# on 2017-12-08 08:39:43 +0000 using RuboCop version 0.51.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -185,7 +185,7 @@ Layout/MultilineHashBraceLayout:
Layout/MultilineMethodCallBraceLayout:
Enabled: false

# Offense count: 29
# Offense count: 28
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver
Expand All @@ -198,7 +198,6 @@ Layout/MultilineMethodCallIndentation:
- 'src/api/app/jobs/project_create_auto_cleanup_requests.rb'
- 'src/api/app/mixins/has_relationships.rb'
- 'src/api/app/models/owner.rb'
- 'src/api/spec/controllers/webui/request_controller_spec.rb'
- 'src/api/spec/features/webui/projects_spec.rb'
- 'src/api/spec/models/repository_spec.rb'
- 'src/api/test/unit/issue_test.rb'
Expand All @@ -211,7 +210,7 @@ Layout/MultilineMethodCallIndentation:
Layout/MultilineOperationIndentation:
Enabled: false

# Offense count: 75
# Offense count: 76
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SupportedStylesForEmptyBraces.
# SupportedStyles: space, no_space
Expand All @@ -228,7 +227,7 @@ Layout/SpaceInLambdaLiteral:
- 'src/api/app/models/package_issue.rb'
- 'src/api/config/routes.rb'

# Offense count: 125
# Offense count: 140
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Expand Down Expand Up @@ -385,7 +384,7 @@ Lint/UriEscapeUnescape:
Metrics/AbcSize:
Max: 248

# Offense count: 411
# Offense count: 413
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 988
Expand All @@ -400,11 +399,11 @@ Metrics/BlockNesting:
Metrics/ClassLength:
Max: 1157

# Offense count: 244
# Offense count: 243
Metrics/CyclomaticComplexity:
Max: 55

# Offense count: 958
# Offense count: 957
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 264
Expand Down Expand Up @@ -660,6 +659,19 @@ Rails/ReversibleMigration:
- 'src/api/db/migrate/20160824132643_fix_bs_request_counter.rb'
- 'src/api/db/migrate/20170103132257_change_project_package_name_to_string.rb'

# Offense count: 7
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Exclude:
- 'src/api/db/migrate/20151030130011_mark_events.rb'
- 'src/api/db/migrate/20161128115942_add_when_attribute_to_bs_request.rb'
- 'src/api/db/migrate/20170621100321_add_channel_to_event_subscriptions.rb'
- 'src/api/db/migrate/20170630144825_convert_tokens_to_service_tokens.rb'
- 'src/api/lib/tasks/project_log_rotate_manually.rake'
- 'src/api/spec/models/bs_request_action_spec.rb'
- 'src/api/spec/models/review_spec.rb'

# Offense count: 98
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Expand Down Expand Up @@ -691,7 +703,7 @@ Style/BlockDelimiters:
Style/BracesAroundHashParameters:
Enabled: false

# Offense count: 83
# Offense count: 67
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: nested, compact
Style/ClassAndModuleChildren:
Expand Down Expand Up @@ -767,7 +779,7 @@ Style/Dir:
Exclude:
- 'src/api/script/start_test_backend'

# Offense count: 634
# Offense count: 631
Style/Documentation:
Enabled: false

Expand Down Expand Up @@ -1054,7 +1066,7 @@ Style/StderrPuts:
Exclude:
- 'src/api/test/functional/webui/spider_test.rb'

# Offense count: 9303
# Offense count: 9358
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand Down

0 comments on commit fe1198a

Please sign in to comment.