Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

original & submitted file icons in Submit Request overview are swapped #15695

Closed
dcermak opened this issue Feb 27, 2024 · 0 comments · Fixed by #15842
Closed

original & submitted file icons in Submit Request overview are swapped #15695

dcermak opened this issue Feb 27, 2024 · 0 comments · Fixed by #15842
Assignees
Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP

Comments

@dcermak
Copy link
Contributor

dcermak commented Feb 27, 2024

Issue Description

The green and red icons that link to the original & submitted file in the new Submitrequest webui are swapped. The green icon with the alt text "see submitted file" points to the original file and the red icon with the alt text "see original file" points to the submitted file.

E.g. https://build.opensuse.org/request/show/1149813/changes:
image

The red icon links to https://build.opensuse.org/package/view_file/devel:BCI:SLCS:next/python-docutils/python-docutils.changes?expand=1&rev=2 while the green links to https://build.opensuse.org/package/view_file/devel:languages:python/python-docutils/python-docutils.changes?expand=1, but it should be the other way around

Expected Result

The links should be swapped

How to Reproduce

  1. Open any submitrequest
  2. go to the changes tab
  3. click either of the see original/submitted file buttons
@danidoni danidoni added Bug Frontend Things related to the OBS RoR app labels Feb 27, 2024
@hennevogel hennevogel added the P2 If possible, assign this to yourself and fix it ASAP label Mar 20, 2024
danidoni added a commit to danidoni/open-build-service that referenced this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants