Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request show redesign feature leads to error 500 after accepting #16030

Closed
Hoorhay opened this issue Apr 22, 2024 · 0 comments · Fixed by #16045
Closed

Request show redesign feature leads to error 500 after accepting #16030

Hoorhay opened this issue Apr 22, 2024 · 0 comments · Fixed by #16045
Assignees
@krauselukas
Labels
Bug Frontend Things related to the OBS RoR app request-redesign Issues about request redesign feature

Comments

@Hoorhay
Copy link

Hoorhay commented Apr 22, 2024

Issue Description

With the redesign feature on, some requests cannot be displayed and show error 500 after accepting it. What they seem to have in common is that patchinfo was provided with them.
The list of affected requests is:
https://build.suse.de/request/show/327260
https://build.suse.de/request/show/327259
https://build.suse.de/request/show/327258
https://build.suse.de/request/show/327257
https://build.suse.de/request/show/327144
https://build.suse.de/request/show/327047

Expected Result

Request's page works after accepting.

How to Reproduce

  1. Go to any of the links in description.
  2. Turn the redesign on and reload the request's page.
  3. See error
  4. Turn redesign off, reload, page works fine.

Further Information
@rubhanazeem rubhanazeem added the request-redesign Issues about request redesign feature label Apr 22, 2024
@hennevogel hennevogel added Bug Frontend Things related to the OBS RoR app labels Apr 22, 2024
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 23, 2024
@krauselukas
Use patchinfo from target package for accepted requests
48025f2 
The source project for maintenance release requests gets
deleted in many cases after it is accepted. Therefore we
have to fetch the patchinfo from the target in those cases.
We also should handle the case of a removed source and target
to prevent nil exceptions.

Fixes openSUSE#16030
@krauselukas krauselukas mentioned this issue Apr 23, 2024
Merged
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 23, 2024
@krauselukas
Use patchinfo from target package for accepted requests
e2f7f5f 
The source project for maintenance release requests gets
deleted in many cases after it is accepted. Therefore we
have to fetch the patchinfo from the target in those cases.
We also should handle the case of a removed source and target
to prevent nil exceptions.

Fixes openSUSE#16030
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 23, 2024
@krauselukas
Use patchinfo from target package for accepted requests
06b4a1d 
The source project for maintenance release requests gets
deleted in many cases after it is accepted. Therefore we
have to fetch the patchinfo from the target in those cases.
We also should handle the case of a removed source and target
to prevent nil exceptions.

Fixes openSUSE#16030
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 24, 2024
@krauselukas
Use patchinfo from target package for accepted requests
e0d3afc 
The source project for maintenance release requests gets
deleted in many cases after it is accepted. Therefore we
have to fetch the patchinfo from the target in those cases.
We also should handle the case of a removed source and target
to prevent nil exceptions.

Fixes openSUSE#16030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krauselukas krauselukas

Labels
Bug Frontend Things related to the OBS RoR app request-redesign Issues about request redesign feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle deleted patchinfos in request workflow beta krauselukas/open-build-service
4 participants
@hennevogel @Hoorhay @rubhanazeem @krauselukas