Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It shouldn't be possible to stage the same package name twice #8730

Closed
coolo opened this issue Nov 18, 2019 · 3 comments · Fixed by #8736 or #8909
Closed

It shouldn't be possible to stage the same package name twice #8730

coolo opened this issue Nov 18, 2019 · 3 comments · Fixed by #8736 or #8909
Labels
Bug staging-workflow Things related to the staging workflow feature

Comments

@coolo
Copy link
Member

coolo commented Nov 18, 2019

As packages are linked, they overwrite each other - so having 2 requests for the same target package is plainly impossible. Still the API doesn't catch it and happily tracks 2 requests for the same package in the same staging project.
@coolo coolo added Bug staging-workflow Things related to the staging workflow feature labels Nov 18, 2019
@coolo coolo mentioned this issue Nov 18, 2019
Closed
@coolo
Copy link
Member Author

coolo commented Nov 18, 2019

screencapture-build-test-opensuse-org-staging-workflows-1-staging-projects-openSUSE-Factory-Staging-adi-17-2019-11-18-12_16_08

@eduardoj
Copy link
Member

We will work on returning an error.

eduardoj added a commit to eduardoj/open-build-service that referenced this issue Nov 18, 2019
@eduardoj
Prevent staging package twice
ee27afa 
Having two requests for the same target package makes no sense.

Fix openSUSE#8730.

Co-authored-by: David Kang <dkang@suse.com>
@eduardoj eduardoj mentioned this issue Nov 18, 2019
Merged
@eduardoj eduardoj self-assigned this Nov 18, 2019
@eduardoj eduardoj removed their assignment Nov 22, 2019
@coolo coolo reopened this Dec 24, 2019
@coolo
Copy link
Member Author

coolo commented Dec 24, 2019

We just had the case again and there is a :bad_request returned - but the request is still staged. This is in some sense even worse

eduardoj added a commit to eduardoj/open-build-service that referenced this issue Jan 3, 2020
@eduardoj
Prevent staging a request with errors
b41909c 
In openSUSE#8736 an error was thrown when a second request for the same target
package wanted to be added, preventing the creation of the linked
package. But the request was still staged.

Now both, the linked package and the staged request are not created.

Fixes openSUSE#8730.

Co-authored-by: David Kang <dkang@suse.com>
@eduardoj eduardoj mentioned this issue Jan 3, 2020
Merged
eduardoj added a commit to eduardoj/open-build-service that referenced this issue Jan 7, 2020
@eduardoj
Prevent staging a request with errors
9bb352f 
In openSUSE#8736 an error was thrown when a second request for the same target
package wanted to be added, preventing the creation of the linked
package. But the request was still staged.

Now both, the linked package and the staged request are not created.

Fixes openSUSE#8730.

Co-authored-by: David Kang <dkang@suse.com>
DavidKang pushed a commit to DavidKang/open-build-service that referenced this issue Jan 7, 2020
@eduardoj
Prevent staging a request with errors
2f81e0e 
In openSUSE#8736 an error was thrown when a second request for the same target
package wanted to be added, preventing the creation of the linked
package. But the request was still staged.

Now both, the linked package and the staged request are not created.

Fixes openSUSE#8730.

Co-authored-by: David Kang <dkang@suse.com>
DavidKang pushed a commit to DavidKang/open-build-service that referenced this issue Jan 7, 2020
@eduardoj
Prevent staging a request with errors
7ed7273 
In openSUSE#8736 an error was thrown when a second request for the same target
package wanted to be added, preventing the creation of the linked
package. But the request was still staged.

Now both, the linked package and the staged request are not created.

Fixes openSUSE#8730.

Co-authored-by: David Kang <dkang@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug staging-workflow Things related to the staging workflow feature
Projects
None yet
Milestone
No milestone
2 participants
@eduardoj @coolo