Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong file name for files with same content/hash #9352

Closed
ismail opened this issue Apr 8, 2020 · 4 comments · Fixed by #9390
Closed

Wrong file name for files with same content/hash #9352

ismail opened this issue Apr 8, 2020 · 4 comments · Fixed by #9390
Assignees
@krauselukas
Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP

Comments

@ismail
Copy link
Contributor

ismail commented Apr 8, 2020

https://build.opensuse.org/package/show/hardware:boot/raspberrypi-firmware shows two "raspberry-firmware.changes" file, identical in size. But in reality there are two different files:

sisyphus ~/work/obs/hardware:boot/raspberrypi-firmware > sha1sum *.changes
8b484e2bf0ad6dabdfe12eaab73e403e73d1a4bd raspberrypi-firmware-config.changes
8b484e2bf0ad6dabdfe12eaab73e403e73d1a4bd raspberrypi-firmware.changes

... with same content & hash. Probably this results in showing the wrong filename for the -config variant.
@eduardoj eduardoj added Bug Frontend Things related to the OBS RoR app labels Apr 8, 2020
@ismail
Copy link
Contributor Author

ismail commented Apr 9, 2020 •
edited
Loading

This looks fine now, did something change on the server side?

Ok, there was an update on the project which fixed the issue (caching?), now to reproduce check an old project like: https://build.opensuse.org/package/show/devel:gcc/gcc7

@krauselukas
Copy link
Contributor

Thanks for the report @ismail, I can reproduce it. Could be related to the caching, need to check it first though

@hennevogel hennevogel added the P2 If possible, assign this to yourself and fix it ASAP label Apr 9, 2020
@ismail
Copy link
Contributor Author

ismail commented Apr 14, 2020

There seems to be a wide-spread issue with numbers not updating which smells like a caching issue. Like my tasks is stuck at "11" even though I have some hundred SRs in the queue.

@hennevogel hennevogel mentioned this issue Apr 14, 2020
Closed
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 15, 2020
@krauselukas @eduardoj
Take file name into account for file partial caching
85c1fda 
In certain cases, the md5 and mtime value of a file is the same
for multiple files. Only the file name differs in those cases.
This needs to be considered, in order to have uniq data in the
cache.

In the past this lead to not show certain files in the
webui due to this rails/rails#35145
Since this got fixed, it now does the opposite (showing duplicated entries),
which is more obvious.

Since osc shows the correct files, and missing files are less
obvious than duplicates, this probably took a while to be reported
as an issue.

Fixes openSUSE#9352

Co-authored-by: David Kang <dkang@suse.com>
Co-authored-by: Eduardo Navarro <enavarro@suse.com>
@krauselukas krauselukas mentioned this issue Apr 15, 2020
Merged
krauselukas added a commit to krauselukas/open-build-service that referenced this issue Apr 15, 2020
@krauselukas
Use cache version to fetch cached users tasks
43acc2a 
Since Ruby on Rails introduced recycable cache keys, which
we enabled with the migration to Rails 6.0, we need to pass
the cache_version in combination with the cache_key (which
now is a stable value) in order to receive the most
recent data.

Related to openSUSE#9352
@krauselukas krauselukas mentioned this issue Apr 15, 2020
Merged
@danidoni
Copy link
Contributor

Cache bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krauselukas krauselukas

Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take file name into account for file partial caching krauselukas/open-build-service
5 participants
@danidoni @ismail @eduardoj @hennevogel @krauselukas