Marking a notification as read: couple of fixes #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoj
added
Frontend
|
Review app will appear here: http://obs-reviewlab.opensuse.org/eduardoj-fix_10173_notifications_preserve_pagination |
dmarcoux
approved these changes
Sep 21, 2020
src/api/app/controllers/webui/users/notifications_controller.rb
Outdated
Show resolved
Hide resolved
... a notification. This will preserve the current pagination page and if all the results are shown, when a notification is marked as read.
... from "Show all" to "Show less", and viceversa. For example, keeping the second page of results when they change from being paginated from bunchs of 25 to bunchs of 300 results, brings no value.
... marking as read the only notification of the last page. This way, a page with no results will not be shown.
eduardoj
force-pushed
the
fix_10173_notifications_preserve_pagination
branch
from
0ede7a8
to
e0adca5
Compare
dmarcoux
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve
pageandshow_allparameters after marking a notification as read. Fixes #10173 and fixes #10181.Also related, take the user to the last pagination page, when the only notification of the last page is marked as read. Reported in #10173.
And last, after clicking in a page of several notifications (not the first page), and then clicking on the "Show all" button, show the first page of all the results. It makes no sense to preserve the
pageparamenter in the "Show all"/"Show less" button link.I will setup a lot of notifications on the review-app instance, to make it easier to do a review.