Remove / to about routing malarky #10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
force-pushed
the
bugfix/slash-about-malarky
branch
from
d1d2707
to
72d2de4
Compare
|
If you're worried about the removed |
No need to route / and /public/ to controllers that redirect to AboutController#index. Just route to AboutController#index directly.
This only tests that the /distribution API is not reachable if you request HTML. It's not possible unless you use the set_response_format_to_xml before action, which we don't.
hennevogel
force-pushed
the
bugfix/slash-about-malarky
branch
from
f38b11b
to
1d223ee
Compare
hennevogel
force-pushed
the
bugfix/slash-about-malarky
branch
from
1d223ee
to
89b524b
Compare
vpereira
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to route
/and/public/to controllers that redirect to AboutController#index.Just route to AboutController#index directly.