-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI documentation for request endpoints #10637
Conversation
Review app will appear here: http://obs-reviewlab.opensuse.org/krauselukas-api_docsrequest |
68ee114
to
9c70faf
Compare
We should add a note to the endpoints which are running expensive operations. The endpoint |
@@ -0,0 +1,63 @@ | |||
post: | |||
summary: Get the diff for all by the request affected packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this sentence. Is this Get the diff for all packages affected in the request
? I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, the sentence is a bit off, will change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied your suggestion :)
Yes, might be a good idea to mention it, since its also mentioned in the general description of the API |
No please. Calling an inexpensive operation 300 times concurrently is wrong the same way. Let's keep this simple. |
9c70faf
to
65f8630
Compare
True, haven't seen it from this perspective, lets keep it simple then 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work! Thanks!
src/api/public/apidocs-new/paths/request_request_collection.yaml
Outdated
Show resolved
Hide resolved
src/api/public/apidocs-new/paths/request_request_collection.yaml
Outdated
Show resolved
Hide resolved
65f8630
to
8fdc10d
Compare
@eduardoj I addressed your review, please have another look :) |
8fdc10d
to
a7042d7
Compare
a7042d7
to
2ce8d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eduardoj I addressed your review, please have another look :)
Looks good to me. Thanks a lot!
Replace this line with a description of your changes. Please follow the suggestions in the comment below.
If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:
[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature