Fix backend tests #10656
Merged
Fix backend tests #10656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10656 +/- ##
=======================================
Coverage 91.08% 91.09%
=======================================
Files 584 584
Lines 21495 21495
=======================================
+ Hits 19579 19580 +1
+ Misses 1916 1915 -1 |
mlschroe
reviewed
Jan 20, 2021
| @@ -226,7 +226,8 @@ $got = readxml("$ev_dir/$file_name",$BSXML::event); | |||
| $expected = { | |||
| 'repository' => 'openSUSE_Leap_42.1', | |||
| 'project' => 'devel:languages:perl', | |||
| 'type' => 'publish' | |||
| 'type' => 'publish', | |||
| 'time' => time(), | |||
mlschroe
reviewed
Jan 20, 2021
| rmdir $_ || warn "$_: $!" | ||
| } else { | ||
| unlink $_ || warn "$_: $!"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not:
-d $_ ? rmdir $_ : unlink $_ or warn("$_: $!");
without this patch you get warnings like this: t/data/0015/events/x86_64/unblocked::devel:languages:perl::openSUSE_Leap_42.1: No such file or directory at t/0015-BSSched-EventSource-Directory.t line 264. after successful completion of all jobs. This is missleading because $! is _not_ reset and not meant to detect an error.
M0ses
force-pushed
the
fix_backend_tests
branch
from
7ef0b95
to
a5c49a5
Compare
mlschroe
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt test cases to new backend behavior