Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading error message #10666

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

danidoni
Copy link
Contributor

@danidoni danidoni commented Jan 21, 2021

This PR fixes the misleading error message thrown in this endpoint

Replace this line with a description of your changes. Please follow the suggestions in the comment below.


If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:

  • Requires a database migration that can cause downtime. Postpone deployment until maintenance window[1].
  • Contains a data migration that can cause temporary inconsistency, so should be run at a specific point of time.
  • Changes some configuration files (e.g. options.yml), so the changes have to be applied manually in the reference server.
  • A new Feature Toggle[2] should be enabled in the reference server.
  • Proper documentation or announcement has to be published upfront since the introduced changes can confuse the users.

[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature

@danidoni danidoni mentioned this pull request Jan 21, 2021
5 tasks
@danidoni
Copy link
Contributor Author

Person

@dmarcoux dmarcoux added the Frontend Things related to the OBS RoR app label Jan 21, 2021
Copy link
Contributor

@dmarcoux dmarcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment just above the command action is also wrong. I suggest removing it completely.

# Returns a list of all users (that optionally start with a prefix)

src/api/app/controllers/person_controller.rb Outdated Show resolved Hide resolved
@danidoni
Copy link
Contributor Author

danidoni commented Jan 21, 2021

The comment just above the command action is also wrong. I suggest removing it completely.

# Returns a list of all users (that optionally start with a prefix)

Removed

@dmarcoux dmarcoux merged commit 42b7370 into openSUSE:master Jan 21, 2021
@danidoni danidoni deleted the fix-misleading-error-message branch January 21, 2021 14:59
@dmarcoux dmarcoux added the API Things regarding our API label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Things regarding our API Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants