Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'person/{login}/token/{id}' delete method #10679

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Jan 22, 2021

Using OpenAPI.


If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:

  • Requires a database migration that can cause downtime. Postpone deployment until maintenance window[1].
  • Contains a data migration that can cause temporary inconsistency, so should be run at a specific point of time.
  • Changes some configuration files (e.g. options.yml), so the changes have to be applied manually in the reference server.
  • A new Feature Toggle[2] should be enabled in the reference server.
  • Proper documentation or announcement has to be published upfront since the introduced changes can confuse the users.

[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature

Copy link
Contributor

@krauselukas krauselukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krauselukas krauselukas added the Documentation 📖 Things regarding our documentation label Jan 22, 2021
@krauselukas krauselukas merged commit fd09004 into openSUSE:master Jan 22, 2021
@dmarcoux dmarcoux added the API Things regarding our API label Jan 26, 2021
@saraycp saraycp deleted the person_token_delete branch March 31, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Things regarding our API Documentation 📖 Things regarding our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants