Disable editor's save button while it is saving #11533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraycp
added
Frontend
|
Review app will appear here: http://obs-reviewlab.opensuse.org/saraycp-disable-codemirror-save-button |
eduardoj
reviewed
Aug 26, 2021
eduardoj
approved these changes
Aug 26, 2021
saraycp
force-pushed
the
disable-codemirror-save-button
branch
from
948fb5f
to
abde384
Compare
After pressing the save button, the saving can take a while. During that time a progress bar appears and the save button should be disabled to avoid getting many save requests and consequently duplicated revisions of the file.
saraycp
force-pushed
the
disable-codemirror-save-button
branch
from
abde384
to
8fc9aca
Compare
eduardoj
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pressing the save button, the saving can take a while. During that time a progress bar appears and the save button should be disabled to avoid getting many save requests and, consequently, duplicated revisions of the file.
Fixes #11247
How to test?
MetaSave