Report multibuild flavors if package is multibuild #12089
Conversation
vpereira
force-pushed
the
fix_issue_11975
branch
from
29b88a4
to
0bc8544
Compare
vpereira
force-pushed
the
fix_issue_11975
branch
2 times, most recently
from
2b6a180
to
9c5ae4d
Compare
dmarcoux
force-pushed
the
fix_issue_11975
branch
4 times, most recently
from
c2e33b7
to
b2d12e9
Compare
|
can you please seperate the cassette changes from the code changes to make it easier to review? |
dmarcoux
force-pushed
the
fix_issue_11975
branch
from
b2d12e9
to
84c94ea
Compare
Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Co-authored-by: Victor Pereira <vpereira@suse.com>
dmarcoux
force-pushed
the
fix_issue_11975
branch
from
84c94ea
to
7943936
Compare
@hennevogel: Done 🙂 It's also possible to filter files by extension under the
|
| @@ -43,7 +46,7 @@ def create_or_update_subscriptions(package, workflow_filters) | |||
| enabled: true, | |||
| token: @token, | |||
| package: package) | |||
| subscription.update!(payload: scm_webhook.payload.merge({ workflow_filters: workflow_filters, short_package_name: target_package_name(short_commit_sha: true) })) | |||
There was a problem hiding this comment.
We don't use short_package_name anymore in ReportToScmJob where this payload is used, so this why we remove this key from the payload.
| @@ -272,8 +319,7 @@ | |||
|
|
|||
| let(:octokit_client) { instance_double(Octokit::Client) } | |||
| let(:target_project_final_name) { "home:#{user.login}" } | |||
| let(:final_package_name) { "#{package.name}-#{long_commit_sha}" } | |||
| let(:final_short_package_name) { "#{package.name}-#{short_commit_sha}" } | |||
| let(:final_package_name) { "#{package.name}-#{short_commit_sha}" } | |||
There was a problem hiding this comment.
There wasn't a short and long package name, this was wrong.
| @@ -223,6 +219,57 @@ | |||
| it_behaves_like 'fails with insufficient write permission on target project' | |||
| end | |||
|
|
|||
| context 'for a multibuild package' do | |||
There was a problem hiding this comment.
This is mostly a copy-and-paste from the 'successful new PR or MR event' shared context in this file. Shared contexts are a nightmare to maintain and on top of this, it didn't pass for a muiltibuild package, so it had to be changed.
Report to SCM the multibuild flavor if target package is multibuild
Fixes #11975