-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System notifications (proof of concept) #12213
base: master
Are you sure you want to change the base?
Conversation
b99287a
to
f69cb7a
Compare
src/api/app/assets/javascripts/webui/channels/notifications_channel.js
Outdated
Show resolved
Hide resolved
src/api/app/assets/javascripts/webui/channels/notifications_channel.js
Outdated
Show resolved
Hide resolved
src/api/app/assets/javascripts/webui/channels/notifications_channel.js
Outdated
Show resolved
Hide resolved
What about creating a rake task to send the test notification? |
We don't need one atm. For now, we'll just go with |
d00a5f6
to
02ae6d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubhanazeem nice :)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
+ Coverage 88.21% 91.35% +3.13%
==========================================
Files 702 660 -42
Lines 24091 23090 -1001
==========================================
- Hits 21253 21093 -160
+ Misses 2838 1997 -841 |
4f3ed48
to
0c6c6ac
Compare
0c6c6ac
to
52245d9
Compare
This PR is just a proposal for adding system notifications to OBS using the Notifications API and ActionCable.
To test the notifications open the rails console and try to broadcast for the logged-in user.
Be sure to replace
User.first
with a logged-in user.