[webui] Refactor package save_file #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| redirect_to(:back, :error => 'Timeout when saving file. Please try again.') | ||
| elsif file_url.present? | ||
| # we have a remote file URI, so we have to download and save it | ||
| @services = Service.find(project: @project, package: @package.name) |
There was a problem hiding this comment.
Use the proper method for that:
services = @package.services
I don't see the need of using instance variables here... use locals. They aren't sent to any view/template here
ChrisBr
force-pushed
the
refactor_save_file
branch
from
11c7fad
to
bde6d4f
Compare
| else | ||
| redirect_to({:action => :show, :project => @project, :package => @package}, :success => "The file #{filename} has been added.") | ||
|
|
||
| rescue APIException, StandardError => exception |
There was a problem hiding this comment.
With APIException & StandardError we can catch all possible exceptions (Suse::ValidationError is an APIException and ActiveXML::Transport::Error and Timeout::Error are StandardError etc.)
Please review! |
* A new file is an UploadedFile object which caused an Exception in Suse::Validator.validate because it called to_s on UploadedFile * Catches and shows now all Excepton * Some simplifications * Refactoring and improving of the tests This closes openSUSE#1253, closes openSUSE#1315
The submit button is disabled as long as not one of the fields is filled out.
ChrisBr
force-pushed
the
refactor_save_file
branch
from
bde6d4f
to
3d5a575
Compare
|
LGTM |
|
👍 |
hennevogel
added a commit
that referenced
this pull request
Oct 30, 2015
[webui] Refactor package save_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #1253