Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for BsRequestActivityTimelineComponent #13918

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Feb 28, 2023

We had implemented the component but not the specs. Here they are.

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Feb 28, 2023
@saraycp saraycp force-pushed the activity_timeline_component_specs branch from d704f83 to 036c5b0 Compare March 1, 2023 09:55
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #13918 (8325299) into master (8b65c57) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13918      +/-   ##
==========================================
+ Coverage   88.14%   88.18%   +0.04%     
==========================================
  Files         732      732              
  Lines       24483    24483              
==========================================
+ Hits        21580    21591      +11     
+ Misses       2903     2892      -11     

@saraycp saraycp force-pushed the activity_timeline_component_specs branch from 036c5b0 to 8325299 Compare March 1, 2023 11:44
@danidoni
Copy link
Contributor

danidoni commented Mar 1, 2023

Don't we test the presence of the avatar and the creation date?

@saraycp
Copy link
Contributor Author

saraycp commented Mar 2, 2023

Don't we test the presence of the avatar and the creation date?

I don't think it should be part of this spec, as this component is in charge of displaying a comment or a history element in the right order. That's why I check the minimum info possible to simply know if a comment or a history element is displayed and in the right order.

Checking the details of the comments and history elements should be done in the specific components' specs. As I already did with the icon in the specs for the history element I could create new PRs to check for more details...

@danidoni
Copy link
Contributor

danidoni commented Mar 2, 2023

Don't we test the presence of the avatar and the creation date?

I don't think it should be part of this spec, as this component is in charge of displaying a comment or a history element in the right order. That's why I check the minimum info possible to simply know if a comment or a history element is displayed and in the right order.

Okay!

@saraycp saraycp merged commit 14091a0 into openSUSE:master Mar 2, 2023
@saraycp saraycp deleted the activity_timeline_component_specs branch March 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants