-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for BsRequestActivityTimelineComponent #13918
Add specs for BsRequestActivityTimelineComponent #13918
Conversation
src/api/spec/components/bs_request_activity_timeline_component_spec.rb
Outdated
Show resolved
Hide resolved
d704f83
to
036c5b0
Compare
src/api/spec/components/bs_request_activity_timeline_component_spec.rb
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #13918 +/- ##
==========================================
+ Coverage 88.14% 88.18% +0.04%
==========================================
Files 732 732
Lines 24483 24483
==========================================
+ Hits 21580 21591 +11
+ Misses 2903 2892 -11 |
036c5b0
to
8325299
Compare
Don't we test the presence of the avatar and the creation date? |
I don't think it should be part of this spec, as this component is in charge of displaying a comment or a history element in the right order. That's why I check the minimum info possible to simply know if a comment or a history element is displayed and in the right order. Checking the details of the comments and history elements should be done in the specific components' specs. As I already did with the icon in the specs for the history element I could create new PRs to check for more details... |
Okay! |
We had implemented the component but not the specs. Here they are.