Fix arrangement of request show view HTML elements #13923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app will appear here: http://obs-reviewlab.opensuse.org/eduardoj-fixrequest_paragraphs |
eduardoj
force-pushed
the
fix/request_paragraphs
branch
from
de5d176
to
952f5f6
Compare
danidoni
approved these changes
Mar 1, 2023
eduardoj
force-pushed
the
fix/request_paragraphs
branch
from
952f5f6
to
80a6fbe
Compare
eduardoj
commented
Mar 1, 2023
Fix including `<p>` elements inside other `<p>` elements in the requests and actions views. That results in an invalid HTML, and the HAML parser was preventing this from happening creating `<p></p>` groups of HTML elements. A series of changes have been made in this pull request: - Rearrange the title of the card and the text of the card, adjusting margins. Before, all the text belonged to the `card-title` CSS class. - Substitute `font-italic` with `fst-italic`. This should have been changed in the migration to Bootstrap 5. - Wrap simple text not including `<p>` elements into `<p>` elements. - Wrap the rest of the text groups into `<div>` elements with the following classes: `.d-flex.flex-wrap.mb-3.align-items-center`. That allowed to remove the use of `.align-middle`.
eduardoj
force-pushed
the
fix/request_paragraphs
branch
from
80a6fbe
to
825462e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #13923 +/- ##
==========================================
+ Coverage 88.19% 88.21% +0.02%
==========================================
Files 732 732
Lines 24498 24492 -6
==========================================
Hits 21606 21606
+ Misses 2892 2886 -6 |
saraycp
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix including
<p>elements inside other<p>elements in the requests and actions views. That results in an invalid HTML, and the HAML parser was preventing this from happening creating<p></p>groups of HTML elements.A series of changes have been made in this pull request:
card-titleCSS class.font-italicwithfst-italic. This should have been changed in the migration to Bootstrap 5.<p>elements into<p>elements.<div>elements with the following classes:.d-flex.flex-wrap.mb-3.align-items-center. That allowed to remove the use of.align-middle.