Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] re-schedule auto-accept job in special case #14047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianschroeter
Copy link
Member

When the embargo date blocked the release eg. via approver mechanic.

In that case the request just stays open forever, so let's reschedule the accept based on the embargo time

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Mar 21, 2023
@adrianschroeter adrianschroeter force-pushed the fix-accept-reschedule-after-embargo branch from c5ad02e to e7981ec Compare March 21, 2023 11:53
@adrianschroeter adrianschroeter force-pushed the fix-accept-reschedule-after-embargo branch 2 times, most recently from aa145d3 to b2973fc Compare April 4, 2023 12:50
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 88.12%. Comparing base (040e40f) to head (b2973fc).

❗ Current head b2973fc differs from pull request most recent head 94002f0. Consider uploading reports for the commit 94002f0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14047      +/-   ##
==========================================
+ Coverage   86.00%   88.12%   +2.11%     
==========================================
  Files         794      733      -61     
  Lines       26049    24560    -1489     
==========================================
- Hits        22404    21644     -760     
+ Misses       3645     2916     -729     

When the embargo date blocked the release eg. via approver mechanic.

In that case the request just stays open forever, so let's reschedule the
accept based on the embargo time
@bugfinder bugfinder force-pushed the fix-accept-reschedule-after-embargo branch from b2973fc to 94002f0 Compare April 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant