Add readers to BuildFail notifications #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
force-pushed
the
notification
branch
3 times, most recently
from
5d3acc7
to
7843f2e
Compare
This will allow third parties to watch build failures in projects they are listed as readers (watchers). Signed-off-by: Dinar Valeev <dvaleev@suse.com>
|
Looks good to me codewise. @adrianschroeter This would cause mails to be send to all users subscribed as readers. Any concerns with such a change? Otherwise I would merge this one |
|
fine with me. Just fixed the commit message and submitting this via pull request #1463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow third parties to watch build failures in projects
they are listed as readers (watchers).
Signed-off-by: Dinar Valeev dvaleev@suse.com