Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the remaining database tables and columns to utf8mb4 #14597

Merged
merged 4 commits into from Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 8 additions & 14 deletions src/api/.rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
# on 2023-07-26 21:22:14 UTC using RuboCop version 1.55.0.
# on 2023-08-01 12:11:47 UTC using RuboCop version 1.55.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -157,7 +157,7 @@ Lint/UselessMethodDefinition:
- 'app/controllers/webui/requests/submissions_controller.rb'
- 'test/test_helper.rb'

# Offense count: 877
# Offense count: 878
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 254
Expand All @@ -176,7 +176,7 @@ Metrics/BlockNesting:
- 'lib/xpath_engine.rb'
- 'test/node_matcher.rb'

# Offense count: 81
# Offense count: 82
# Configuration parameters: CountComments, Max, CountAsOne.
Metrics/ClassLength:
Exclude:
Expand Down Expand Up @@ -230,6 +230,7 @@ Metrics/ClassLength:
- 'app/models/workflow.rb'
- 'app/models/workflow/step.rb'
- 'app/services/user_service/involved.rb'
- 'db/migrate/20230727110437_migrate_to_utf8mb4.rb'
- 'lib/xpath_engine.rb'
- 'test/functional/attributes_test.rb'
- 'test/functional/binary_release_test.rb'
Expand Down Expand Up @@ -352,7 +353,7 @@ Metrics/CyclomaticComplexity:
- 'test/functional/zzz_post_consistency_test.rb'
- 'test/node_matcher.rb'

# Offense count: 956
# Offense count: 957
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
Max: 221
Expand Down Expand Up @@ -1208,7 +1209,7 @@ Style/ConditionalAssignment:
Exclude:
- 'app/models/bs_request_action_submit.rb'

# Offense count: 988
# Offense count: 989
# Configuration parameters: AllowedConstants.
Style/Documentation:
Enabled: false
Expand All @@ -1220,7 +1221,7 @@ Style/ExplicitBlockArgument:
- 'app/lib/backend/connection.rb'
- 'app/models/project.rb'

# Offense count: 1722
# Offense count: 1723
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Expand Down Expand Up @@ -1297,13 +1298,6 @@ Style/RedundantFreeze:
Exclude:
- 'lib/pretty_nested_errors/key_and_messages_parser.rb'

# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowedMethods, AllowedPatterns.
Style/ReturnNilInPredicateMethodDefinition:
Exclude:
- 'app/policies/package_policy.rb'

# Offense count: 11
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/SlicingWithRange:
Expand Down Expand Up @@ -1401,7 +1395,7 @@ ViewComponent/MissingPreviewFile:
- 'app/components/workflow_run_row_component.rb'
- 'app/components/write_and_preview_component.rb'

# Offense count: 2482
# Offense count: 2668
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Expand Down