Request description as part of the conversation history #14607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
request-description-text
branch
3 times, most recently
from
375b1da
to
2529d90
Compare
ncounter
force-pushed
the
request-description-text
branch
from
2529d90
to
53bc893
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14607 +/- ##
==========================================
+ Coverage 84.42% 87.19% +2.77%
==========================================
Files 744 744
Lines 25015 25015
==========================================
+ Hits 21119 21812 +693
+ Misses 3896 3203 -693 |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/ncounter-request-description-text |
danidoni
reviewed
Jul 6, 2023
danidoni
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scope of highlighting more the
BsRequestdescription, it is a fact that the description itself is the initial comment of the request, so it is the root from where the history starts.With this PR the description has its own title and box, and the history timeline starts from this box.
By doing this, the aside column with all the other information (reviewers, maintainers, etc) are aligned with the top of the Conversation tab panel.
Before
After