[api] implement package fork command #14830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation 📖
|
Review app will appear here: http://obs-reviewlab.opensuse.org/adrianschroeter-fork_command |
adrianschroeter
force-pushed
the
fork_command
branch
2 times, most recently
from
ba424f8
to
4c7d0e2
Compare
|
@eduardoj btw, I failed to find a way to define parameters optional or required in the docu, is there a way? |
By default they are optional. To mark them as required, use: If you made some change in your development environment and didn't notice any change after reloading the page, please read: https://github.com/openSUSE/open-build-service/wiki/New-Swagger-API-doc#how-to-test-it For reference: https://swagger.io/docs/specification/describing-parameters/#required-optional Thank you for your effort on documenting this! |
adrianschroeter
force-pushed
the
fork_command
branch
2 times, most recently
from
78bb918
to
60570ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14830 +/- ##
=======================================
Coverage 86.04% 86.05%
=======================================
Files 793 793
Lines 25963 25982 +19
=======================================
+ Hits 22340 22358 +18
- Misses 3623 3624 +1 |
hennevogel
reviewed
Aug 24, 2023
|
On Donnerstag, 24. August 2023, 13:12:42 CEST Henne Vogelsang wrote:
@hennevogel commented on this pull request.
> @@ -712,6 +712,22 @@ Parameters:
XmlResult: status
+POST /source/<project>/<package>?cmd=fork&scmsync=url
I'm not sure I'd like to introduce another term for this. Can't we just make this an optional parameter for branch?
this term is known from git world and it is intenionally not "branch"
as it will not create a branch in the backend.
It is an independ instantiation without any auto-merging mechanics
from OBS side.
The branch tracking and merging must happen on git side.
…--
Adrian Schroeter ***@***.***>
Build Infrastructure Project Manager
SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nürnberg, Germany
(HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
|
dcermak
reviewed
Aug 29, 2023
github-actions
bot
added
Backend
hennevogel
force-pushed
the
fork_command
branch
from
e0b4868
to
d29b18b
Compare
github-actions
bot
removed
Backend
hennevogel
force-pushed
the
fork_command
branch
2 times, most recently
from
5831131
to
34df36e
Compare
adrianschroeter
commented
Aug 31, 2023
hennevogel
removed
the
review-app
adrianschroeter
force-pushed
the
fork_command
branch
2 times, most recently
from
47882f8
to
45a094e
Compare
|
given that Eduardo and Henne have also work on it, I assume this is fine now and will merge it next week. (ignoring the random test suite failures which are unrelated). |
This can be used to create a test build setup for a scmsync package based on an existing project. The base package may or may not exist. May or may not use scmsync. This is mainly implemented inside of BranchPackage class intentionaly, even when this is no source branch technically. But many api parts like repository setup can be shared this way. Co-Author: Henne Vogelsang <hvogel@opensuse.org>
hennevogel
approved these changes
Mar 1, 2024
|
@adrianschroeter sorry, this fell through my cracks... |
hennevogel
added a commit
to hennevogel/open-build-service
that referenced
this pull request
Mar 8, 2024
This got lost in openSUSE#14830
hennevogel
added a commit
to hennevogel/open-build-service
that referenced
this pull request
Mar 8, 2024
Fixes openSUSE#15770 This got lost somehow in openSUSE#14830
hennevogel
added a commit
to hennevogel/open-build-service
that referenced
this pull request
Mar 8, 2024
Fixes openSUSE#15770 This got lost somehow in openSUSE#14830
hennevogel
added a commit
to hennevogel/open-build-service
that referenced
this pull request
Mar 19, 2024
In case the target package already exists for some reason - this is an updated pull request - the target package was created previously we still need to update the scmsync attribute. This broke with openSUSE#14830
hennevogel
added a commit
to hennevogel/open-build-service
that referenced
this pull request
Mar 19, 2024
In case the target package already exists for some reason - this is an updated pull request - the target package was created previously we still need to update the scmsync attribute. This broke with openSUSE#14830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to create a test build setup for a scmsync package based on an existing project.
The base package may or may not exist. May or may not use scmsync.
This is mainly implemented inside of BranchPackage class intentionaly, even when this is no source branch technically. But many api parts like repository setup can be shared this way.