Autocorrect some RuboCop offenses (III) #15153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Frontend
eduardoj
force-pushed
the
refactoring/rubocop_safe_autocorrections_iii
branch
8 times, most recently
from
419618a
to
f976205
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15153 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 778 778
Lines 25617 25562 -55
=======================================
- Hits 22441 22394 -47
+ Misses 3176 3168 -8 |
|
Can we do something about the issues CodeClimate is complaining about? |
codeclimate reports 9 issues fixed and 2 new issues to fix. Those 2 new issues have poped up after refactoring the code. I would say they are in fact the same as before. |
eduardoj
force-pushed
the
refactoring/rubocop_safe_autocorrections_iii
branch
2 times, most recently
from
5644943
to
0d00468
Compare
danidoni
approved these changes
Nov 3, 2023
eduardoj
force-pushed
the
refactoring/rubocop_safe_autocorrections_iii
branch
from
0d00468
to
a82c6ad
Compare
Correcting Style/SoleNestedConditional offenses introduced other types of offenses. Add those new offenses to the TODO.
eduardoj
force-pushed
the
refactoring/rubocop_safe_autocorrections_iii
branch
from
a82c6ad
to
d69e686
Compare
... RuboCop offenses
Don't consider migration what is outside db/migrate/ or db/data/, or their schema files.
|
@danidoni, I needed to rebase on master. After that, new I also added a commit to improve the definition of migrations for the "Isolated Migrations" GitHub action. Please take a look again. |
danidoni
approved these changes
Nov 3, 2023
|
I approved the two codeclime issues. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.