Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install activestorage into OBS #16005

Merged
merged 1 commit into from Apr 26, 2024
Merged

Install activestorage into OBS #16005

merged 1 commit into from Apr 26, 2024
+111 −4

Conversation

hellcp-work
Copy link
Contributor

@hellcp-work hellcp-work commented Apr 17, 2024 •
edited

Allows upload of various images to be used in the frontend. Following https://edgeguides.rubyonrails.org/active_storage_overview.html

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Apr 17, 2024
@github-actions GitHub Actions
Copy link

⚠️ Please make sure the migration is shipped in an independent Pull Request. ⚠️
✔️ You can include schema changes, annotations and validations for consistency but ❌ avoid committing other changes with it.

@hellcp-work hellcp-work mentioned this pull request Apr 17, 2024
Open
@danidoni
Copy link
Contributor

How comes that logo is a text? What are you going to store there?

@danidoni
Copy link
Contributor

How comes that logo is a text? What are you going to store there?

Uh, I saw the referenced PR, I understand now.

@hellcp-work hellcp-work marked this pull request as draft April 17, 2024 15:47
@hennevogel
Copy link
Member

This is not how you upload files in rails. Please use active storage.

@hellcp-work hellcp-work marked this pull request as ready for review April 18, 2024 07:36
@hellcp-work
Copy link
Contributor Author

This requires a few packaging changes, the spec file needs to include the new config/storage.yml, and there needs to be a storage directory in api path that can be written to by the apache user.

@hennevogel
Copy link
Member

This requires a few packaging changes

The spec file is in this repo too :)

@hellcp-work
Copy link
Contributor Author

The spec file is in this repo too :)

This was a note for me right now trying to fix it so that I don't forget about this

@hellcp-work hellcp-work force-pushed the logo-upload branch 3 times, most recently from 34460ad to 3ad736b Compare April 18, 2024 14:21
@hellcp-work hellcp-work changed the title Add logo configuration column in the database Install activestorage into OBS Apr 18, 2024
@hennevogel hennevogel merged commit ca25901 into openSUSE:master Apr 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel hennevogel left review comments

@eduardoj eduardoj eduardoj approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hellcp-work @danidoni @hennevogel @eduardoj