Do not call link_to_reportable if reportable does not exist
#16063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call the `link_to_reportables` helper on the report show view. This throws an `nil` exception when the reportable is deleted, since the `reportable_type` gets nullified as well. `link_to_reportable` works in on the email notification since the `reportable_type` is still available from the event payload, but we cannot retrieve it from the report record. Fixes openSUSE#16062
|
To not forget that we might need to follow up on this, this is just a quick fix... https://trello.com/c/QCKsR63j/118-refactor-the-usage-of-the-linktoreportables-helper |
hellcp-work
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call the
link_to_reportableshelper on the report show view. This throws annilexception when the reportable is deleted, since thereportable_typegets nullified as well.link_to_reportableworks in on the email notification since thereportable_typeis still available from the event payload, but we cannot retrieve it from the report record.Fixes #16062