Speed up query #16110
Merged
Speed up query #16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With those two methods we are checking for a maintainer relationship with Project/Packages for the user. The Project/Package default scope hides Project that are access disabled and where the user has *no* maintainer relationship to. So both *can not* be true are the same time. No need to skip hidden projects in the query.
By running the involved_projects/involved_packages queries up front, this reduces the amount of temporary tables that have to be populated from 16(!) to 4.
hennevogel
force-pushed
the
refactoring/user-requests-queries
branch
from
5f72912
to
319fed1
Compare
saraycp
approved these changes
May 8, 2024
|
Looks reasonable. Is there any way to test this, or demonstrate that it does what we expect in a repeatable way? Those kinds of tests can be expensive, though. |
I'm afraid the only reasonable way is to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the amount of tables that have to be materialized for getting involved packages / requests.