[api] Merge! is deprecated

[Ana06]

Method merge! is deprecated and will be removed in Rails 5.1, as no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.0.1/classes/ActionController/Parameters.html

[Ana06]

(2) Go through deprecation warnings (deprecated with 5.1) and solve them

[hennevogel]

Looks like you broke requests...

[Ana06]

I've fixed it, but I still don't know why it was failing before. With this code:

roles = params[:roles].split(',') if params[:roles]
types = params[:types].split(',') if params[:types]
states = params[:states].split(',') if params[:states]
review_states = params[:reviewstates].split(',') if params[:reviewstates]
ids = params[:ids].split(',').map { |i| i.to_i } if params[:ids]
params = params.merge({states: states, types: types, review_states: review_states, roles: roles, ids: ids})

I get this in the log when running the tests:

[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] Completed 500 Internal Server Error in 0ms (ActiveRecord: 0.0ms | Backend: 0.0ms | XML: 0.0ms)
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83]   
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] NoMethodError (undefined method `merge' for nil:NilClass):
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83]   
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] app/controllers/request_controller.rb:37:in `render_request_collection'
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] app/controllers/request_controller.rb:16:in `index'
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] config/initializers/wrap_parameters.rb:38:in `call'
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] test/test_helper.rb:184:in `process_with_kwargs'
[e4d32cd3-66fb-4999-82cf-4ebec35403e6] [4842:-200846929.83] test/functional/maintenance_test.rb:1295:in `test_create_maintenance_project_and_release_packages'

Although params is not nil. Why does it say that is nil? any clue?

[hennevogel]

LGTM

[Ana06]

In case that someone is curious.

I've fixed it, but I still don't know why it was failing before. [...] Although params is not nil. Why does it say that is nil? any clue?

This is how ruby works: if you have a method called foo and you defined a local variable called foo assigning the value of foo with something the foo in the right side of the expression will be the local variable in the left side.

$ irb
>> def foo
>>   {}
>>   end
=> :foo
>> foo = foo.merge(a: 1)
NoMethodError: undefined method `merge' for nil:NilClass
    from (irb):4
    from /Users/rafaelfranca/.rbenv/versions/2.3.1/bin/irb:11:in `<main>'

And params is a method, so it was wrong and this is the way to solve it (although I prefer the solution that has already been merged):

self.params = self.params.merge({states: states, types: types, review_states: review_states, roles: roles, ids: ids})

References:

• In Rails 5 params.merge raises exception rails/rails#26875 (comment)
• http://api.rubyonrails.org/classes/ActionController/StrongParameters.html#method-i-params-3D

[bgeuken]

Great that you took the effort to figure out the root cause. Well done