[api] Make image template page look amazing!! #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work |
bgeuken
reviewed
Nov 25, 2016
| word-break: break-all | ||
|
|
||
| /* Non standard for webkit */ | ||
| word-break: break-word |
There was a problem hiding this comment.
Doesn't this line overwrite the previous one?
There was a problem hiding this comment.
only if the browser understands it - i.e. webkit. All other browsers will ignore it as syntax error.
There was a problem hiding this comment.
Right! Only if the browser supports it.
There was a problem hiding this comment.
I see.
btw the indentation seems to be wrong
bgeuken
reviewed
Nov 25, 2016
| = link_to(title_or_name(template), package_show_path(project: project, package: template)) | ||
| %span.description.grey | ||
| %span.description.grey.break-words |
There was a problem hiding this comment.
and thumbs up for using a class and not an id for styling 👍
Style changes in the image template page: - Show more test from the name and description. - Do not hide any word of the name/description because it is too long. - `...` is shown when the name/description is too long (if the browser supports it). - Project name in bold. - Reduce top padding for title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style changes in the image template page:
...is shown when the name/description is too long (if the browser supports it).Now it looks amazing!!
Before:
Now:
Chromium
Firefox