New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap: change from ping to ldap attempts #2713

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@suihkulokki
Contributor

suihkulokki commented Feb 20, 2017

ICMP ping might be disabled between the ldap server and OBS. ping
test is not very good, as it doesn't tell if LDAP is actually running
on the server.

Instead just try connecting ldap server until ldap_max_attempts is
reached.

ldap: change from ping to ldap attempts
ICMP ping might be disabled between the ldap server and OBS. ping
test is not very good, as it doesn't tell if LDAP is actually running
on the server.

Instead just try connecting ldap server until ldap_max_attempts is
reached.
@suihkulokki

This comment has been minimized.

Show comment
Hide comment
@suihkulokki

suihkulokki Feb 20, 2017

Contributor

Before the fixing the whitespace issue in the earlier version of this PR, the rspec test succeeded:

https://travis-ci.org/openSUSE/open-build-service/builds/203385647

Contributor

suihkulokki commented Feb 20, 2017

Before the fixing the whitespace issue in the earlier version of this PR, the rspec test succeeded:

https://travis-ci.org/openSUSE/open-build-service/builds/203385647

@hennevogel

This comment has been minimized.

Show comment
Hide comment
@hennevogel

hennevogel Mar 3, 2017

Member

Makes an awful lot of sense and nicely done. Awesome contribution, keep them coming :-) Thank you @suihkulokki! 💐

Member

hennevogel commented Mar 3, 2017

Makes an awful lot of sense and nicely done. Awesome contribution, keep them coming :-) Thank you @suihkulokki! 💐

@hennevogel hennevogel merged commit d9bc4ea into openSUSE:master Mar 3, 2017

3 checks passed

Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 64.79%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment