ldap: change from ping to ldap attempts #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICMP ping might be disabled between the ldap server and OBS. ping test is not very good, as it doesn't tell if LDAP is actually running on the server. Instead just try connecting ldap server until ldap_max_attempts is reached.
suihkulokki
force-pushed
the
ldap-update
branch
from
e9f0f25
to
7fbf940
Compare
|
Before the fixing the whitespace issue in the earlier version of this PR, the rspec test succeeded: https://travis-ci.org/openSUSE/open-build-service/builds/203385647 |
hennevogel
approved these changes
Mar 3, 2017
|
Makes an awful lot of sense and nicely done. Awesome contribution, keep them coming :-) Thank you @suihkulokki! 💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICMP ping might be disabled between the ldap server and OBS. ping
test is not very good, as it doesn't tell if LDAP is actually running
on the server.
Instead just try connecting ldap server until ldap_max_attempts is
reached.