[ci] Test source_controller #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ana06
added
DO NOT MERGE ⚠️
Ana06
changed the title
bgeuken
reviewed
Mar 6, 2017
| end | ||
|
|
||
| it { expect(response).to be_success } | ||
| it {expect(Xmlhash.parse(response.body)["name"]).to eq(project.name)} |
bgeuken
reviewed
Mar 6, 2017
| put :update_project_config, params: { project: project, comment: 'Updated by test' } | ||
| end | ||
|
|
||
| it { expect(response).to be_success } |
There was a problem hiding this comment.
I would also check if the comment got created
evanrolfe
reviewed
Mar 6, 2017
| # WARNING: If you change owner tests make sure you uncomment this line | ||
| # and start a test backend. Some of the Owner methods | ||
| # require real backend answers for projects/packages. | ||
| # CONFIG['global_write_through'] = true |
There was a problem hiding this comment.
Does this comment apply to all controller specs? Maybe it should go in the test suite guide instead?
https://github.com/evanrolfe/open-build-service/blob/master/src/api/spec/README.md
Also what are the "owner tests" and "owner methods"?
It is tested in `project_controller_tests.rb#test_add_and_modify_repo` of the old test suite so there was a coverage difference between both test suites. I tested it with a simple project, instead with a complex one as it is done in the old test suite as it is not needed. It would be better to test the `Project#to_axml` method with a complex project than doing it here.
Not to all of them, only the ones that gave calls to the backend. And yes we should add it to the guide, I would do it in another PR as it is unrelated. 😉 |
bgeuken
suggested changes
Mar 6, 2017
| before do | ||
| login user | ||
| put :update_project_config, params: { project: project, comment: 'Updated by test' } | ||
| #project.reload |
bgeuken
reviewed
Mar 6, 2017
| end | ||
|
|
||
| it { expect(response).to be_success } | ||
| it { expect(project.config.to_s).to include('Updated', 'by', 'test') } |
There was a problem hiding this comment.
JFYI There should also be a comment instance that got created for the project
|
@Ana06 *ping* |
It is called in teh old test suite from `project_controller_tests.rb#test_updating_config_file`.
bgeuken
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
source_controllermethods that are called in the old test suit fromproject_controller_tests.rb.