Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Evan's migration about cache line key length reversible #2852

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Make Evan's migration about cache line key length reversible #2852

merged 1 commit into from
Mar 17, 2017

Conversation

mdeniz
Copy link
Contributor

@mdeniz mdeniz commented Mar 17, 2017

No description provided.

@mdeniz mdeniz added the Frontend Things related to the OBS RoR app label Mar 17, 2017
@mdeniz mdeniz requested a review from evanrolfe March 17, 2017 11:51
@bgeuken
Copy link
Member

bgeuken commented Mar 17, 2017 •
edited

LGTM, but be aware that this doesn't have any effect on machines that already run that migration. Probably not a big deal since it's just affecting the rollback

@mdeniz
Copy link
Contributor Author

mdeniz commented Mar 17, 2017

Sure, I did it because the rollback...

@DavidKang DavidKang merged commit e2abc10 into openSUSE:master Mar 17, 2017
@mdeniz mdeniz deleted the make_evans_migration_reversible branch May 10, 2017 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanrolfe evanrolfe evanrolfe approved these changes

@DavidKang DavidKang DavidKang approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdeniz @bgeuken @evanrolfe @DavidKang