Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix exception message #2966

Merged
merged 1 commit into from Apr 12, 2017
Merged

[api] Fix exception message #2966

merged 1 commit into from Apr 12, 2017

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Apr 12, 2017

If project doesn't exist, what we shouldn't render if the string we used to look for it and no the project itself, as an empty string will be rendered. :bowtie:

@Ana06 Ana06 added the Frontend Things related to the OBS RoR app label Apr 12, 2017
@ChrisBr
Copy link
Member

ChrisBr commented Apr 12, 2017

LGTM
However, the commit message is a little bit cryptic ;)

If the project doesn't exist, an empty string will be rendered in the error
message.
@ChrisBr
Copy link
Member

ChrisBr commented Apr 12, 2017

@Ana06 feel free to merge as soon as CI finished

@mdeniz mdeniz merged commit 4dd05f9 into openSUSE:master Apr 12, 2017
@codecov
Copy link

codecov bot commented Apr 12, 2017

Codecov Report

Merging #2966 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2966   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         244      244           
  Lines       17214    17214           
=======================================
  Hits        15303    15303           
  Misses       1911     1911
Flag Coverage Δ
#api 84.49% <0%> (ø) ⬆️
#rspec 62.44% <0%> (ø) ⬆️
#webui 64.6% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95e2ac...90802d0. Read the comment docs.

@Ana06 Ana06 deleted the wrong_project branch October 6, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants