Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webui] Handle links properly when doing backend build operations #3284

Merged
merged 2 commits into from
Jun 28, 2017
Merged

[webui] Handle links properly when doing backend build operations #3284

merged 2 commits into from
Jun 28, 2017

Conversation

bgeuken
Copy link
Member

@bgeuken bgeuken commented Jun 26, 2017

Verify that user has write permissions for project before doing backend
call. Added tests to cover new code.

Pair-programmed with @eduardoj and @bgeuken

@bgeuken bgeuken mentioned this pull request Jun 26, 2017
Closed
@mdeniz mdeniz added the Frontend Things related to the OBS RoR app label Jun 26, 2017
@bgeuken bgeuken added the 2.7 label Jun 26, 2017
@adrianschroeter
Copy link
Member

The title is misleading IMHO, this is about to use the project where the actions was triggered and not another one. It has nothing to do with permission checking.

But the code is fine for me.

adrianschroeter and others added 2 commits June 27, 2017 12:53
@adrianschroeter @bgeuken
[webui] Handle links properly when doing backend build operations
d4bddd6 
OBS wasn't properly handling linked projects when triggering rebuilds,
wipe binaries and abort build. This resulted in packages of linked
projects being aborted, wiped, rebuilt.

This fixes the falsey code.

Pair-programmed with @eduardoj and @bgeuken
@bgeuken
[dist] Use 2.7 packages for testing 2.7 branch in travis
be9fc5f
@bgeuken
Copy link
Member Author

bgeuken commented Jun 27, 2017

True. I've updated it now.

@bgeuken bgeuken changed the title [webui] Check permissions before doing backend build operations [webui] Handle links properly when doing backend build operations Jun 27, 2017
@bgeuken bgeuken merged commit afbd787 into openSUSE:2.7 Jun 28, 2017
@bgeuken bgeuken deleted the 2.7_fix branch June 28, 2017 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKang DavidKang DavidKang approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgeuken @adrianschroeter @DavidKang @mdeniz