Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix flaky DoD test #5188

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[ci] Fix flaky DoD test #5188

merged 1 commit into from
Jun 22, 2018

Conversation

coolo
Copy link
Member

@coolo coolo commented Jun 22, 2018

Wait for the repository container to appear before checking
things within it

Wait for the repository container to appear before checking
things within it
@coolo coolo requested a review from DavidKang June 22, 2018 13:06
@DavidKang DavidKang added Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI labels Jun 22, 2018
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @coolo! 💐

@ChrisBr
Copy link
Member

ChrisBr commented Jun 22, 2018

Thanks @coolo ❤️

Copy link
Member

@bgeuken bgeuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice:+1:

@coolo
Copy link
Member Author

coolo commented Jun 24, 2018

it became less flaky and the error message changed, but I needed to run around 30 runs to trigger:

 expected to find visible css ".repository-container" but there were no matches

And the test.log shows that the POST wasn't even done.

@coolo
Copy link
Member Author

coolo commented Jun 24, 2018

Perhaps you put some fonts in the frontend container, so that screenshots are somewhat debuggable :)

screenshot_2018-06-24-07-22-07 733

@coolo
Copy link
Member Author

coolo commented Jun 24, 2018

After sudo zypper in xorg-x11-fonts-core xorg-x11-fonts:

screenshot_2018-06-24-07-56-31 333

So looks all good

@ChrisBr
Copy link
Member

ChrisBr commented Jun 24, 2018

Perhaps you put some fonts in the frontend container, so that screenshots are somewhat debuggable :)

Lol! Added the xorg-x11-fonts-core xorg-x11-fonts package to the base containers.

@adrianschroeter
Copy link
Member

adrianschroeter commented Jun 25, 2018 via email

@coolo
Copy link
Member Author

coolo commented Jun 25, 2018

technically any font will do and in normal development environments you will have some fonts around. So these are hardly dependencies of obs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants