Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Try with docker build OBS images #5257

Merged
merged 2 commits into from Jul 3, 2018

Conversation

ChrisBr
Copy link
Member

@ChrisBr ChrisBr commented Jun 28, 2018

I built the docker images now with native docker and used the bundle gems service. Let's see if CI works.

https://build.opensuse.org/project/show/home:cbruckmayer:containers

@ChrisBr
Copy link
Member Author

ChrisBr commented Jun 28, 2018

@hennevogel now I remember what the problem was with the user:

In the kiwi build we set the frontend user
https://build.opensuse.org/package/view_file/OBS:Server:Unstable:container:SLE12:SP3/frontend-base/config.kiwi?expand=1
which is fine for CI because we want to run the tests as frontend user. However, for development we need to set the root user as we need to do the user id mapping.

Solution would be that we set root user in the frontend-base image and need to switch the user in the CI run to frontend.

@hennevogel
Copy link
Member

Solution would be that we set root user in the frontend-base image and need to switch the user in the CI run to frontend.

Or the other way around like we did in Dockerfile and Dockerfile.frontend-base:

root frontend root -> root frontend

@ChrisBr
Copy link
Member Author

ChrisBr commented Jun 29, 2018

Or the other way around like we did in Dockerfile and Dockerfile.frontend-base:
root frontend root -> root frontend

This is what we do now, this is why the CI fails! The problem is that in CI we use the frontend-base container and not frontend (because we don't want to build). So nothing is switching it back to frontend.

@ChrisBr ChrisBr force-pushed the ci/bundle-cache branch 8 times, most recently from c1020d4 to 31817fa Compare July 3, 2018 09:51
@ChrisBr ChrisBr changed the title [WIP] Try with docker build OBS images [CI] Try with docker build OBS images Jul 3, 2018
because we changed to use Docker to build the images in OBS.
Therefore we set now the root user for the frontend-base image
to be similar to the development frontend-base image.
Therefore we need to switch now to the frontend user in CircleCI
to execute the tests not as root user.
as we changed how we build the docker images in OBS to include a bundle cache already.
This bundle cache is now installed into the system bunde directory
so we need to change the CircleCI cache as well.
@ChrisBr
Copy link
Member Author

ChrisBr commented Jul 3, 2018

I tested the images and they seem to work. They're still in my home directory but I will move them over to the O:S:U subproject now. As soon as they finished building, our CI most likely will start to fail. Not 100% sure if we can already merge this PR before.

@ChrisBr ChrisBr added the Frontend Things related to the OBS RoR app label Jul 3, 2018
@hennevogel
Copy link
Member

Not 100% sure if we can already merge this PR before.

Because?

@ChrisBr
Copy link
Member Author

ChrisBr commented Jul 3, 2018

Because?

I need to wait if CircleCI is complaining ... 😄

@coolo
Copy link
Member

coolo commented Jul 3, 2018

the circleci complaint is about the rename, so go ahead :)

@ChrisBr ChrisBr merged commit 1c032d2 into openSUSE:master Jul 3, 2018
@ChrisBr ChrisBr deleted the ci/bundle-cache branch August 10, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants