Circleci: merge the linting into the checkout_code job #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I can run the linting during checkout code without running database. Brining up the database is easily a minute
2000 seems too little, it's always deleting files after every run - even though it only has 1023 files to inspect atm
If linting fails, we want to die quick
ChrisBr
approved these changes
Jul 12, 2018
.circleci/config.yml
Outdated
| - src/api/tmp/rubocop_cache | ||
| - src/api/tmp/rubocop_cache_root_dir | ||
| - src/api/tmp/rubocop_cache_rails_dir | ||
| - run: rm -rf src/api/tmp/rubocop* |
There was a problem hiding this comment.
Saving space in the repo cache as we already store it in a different cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With proper rubocop caching, it only takes a couple of seconds.