Refactor package partial links (_side_links) #5854
Conversation
| = link_to "error#{failures == 1 ? '' : 's'}", project_monitor_path(project: project, pkgname: package.name, succeeded: 0, | ||
| blocked: 0, finished: 0, signing: 0, dispatching: 0, | ||
| scheduled: 0, building: 0) | ||
| = render partial: 'show_failures', locals: { failures: failures, pkgname: package.name, project: project } |
There was a problem hiding this comment.
[Nitpick]: Could you change pkgname to package_name, please
There was a problem hiding this comment.
if you are saying to change it in the view, doable nitpick, but I won't touch in the controller https://github.com/vpereira/open-build-service/blob/da08d94faa5c84c1ba3bc175c38c61584976cad2/src/api/app/controllers/webui/project_controller.rb#L390-L391 where the GET param name is pkgname
There was a problem hiding this comment.
@vpereira, only in the view 👍
|
I would squash the commits, we don't need this amount of details when it's about splitting a partial. How about this |
first I have to figure out why the tests aren't green. Therefore I prefer to have it now as single commits. Before merge I will squash it. thank you |
vpereira
force-pushed
the
refactor_package_partial_links
branch
3 times, most recently
from
52bfe49
to
703e719
Compare
vpereira
force-pushed
the
refactor_package_partial_links
branch
from
703e719
to
bd6f525
Compare
| %li | ||
| %i.fas.fa-times-circle.text-danger{ title: 'Errors' } | ||
| = failures | ||
| = link_to "error#{failures == 1 ? '' : 's'}", project_monitor_path(project: project, pkgname: package_name, succeeded: 0, |
There was a problem hiding this comment.
Nice use case for pluralize
Refactor the partial _side_links for packages, breaking it in smaller partials