Fix comments in old webui #5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are a beta user, the comments section are rendering the views from `webui2` in sections that are not migrated like `project#show`. The `no_switch` was added in `webui` comment views because they will be deleted as soon as we migrate everything to Bootstrap, Co-authored-by: Moisés Déniz Alemán <mdeniz@suse.com>
DavidKang
added
Frontend
ChrisBr
approved these changes
Sep 19, 2018
dmarcoux
approved these changes
Sep 19, 2018
|
Review app will appear here: http://obs-reviewlab.opensuse.org/davidkang-fixcomments |
eduardoj
approved these changes
Sep 19, 2018
|
I checked the review app, everything works again! Thanks for the quick fix @mdeniz & @DavidKang |
|
This seems to become a thing now right? It's the second or third time we have to do something like this. I wonder if we need a general solution for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a beta user, the comments section are rendering the views
from
webui2in sections that are not migrated likeproject#show.The
no_switchparameter was added inwebuicomment views because they will bedeleted as soon as we migrate everything to Bootstrap,
Co-authored-by: Moisés Déniz Alemán mdeniz@suse.com
Fixes #5874