Update bootstrap master #5973
Merged
Update bootstrap master #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Checks and @missing_checks can be nil so we need to check blank instead of empty.
Merge bootstrap-master back to master
Bootstrap master
There was a strange effect between long and short pages, as the second ones were hiding the scrollbar. Showing always the scrollbar fixes that issue. Fixes openSUSE#5939
Fix Nil exception in staging dashboard
Fix flickering views in webui2
Index files are ignored by wildcards in the assets pipeline initializer since they have a special meaning in Sprockets. Details at https://edgeguides.rubyonrails.org/asset_pipeline.html#using-index-files
…_file Create Bootstrap version of package#view_file
We are using review apps for reviewing UI changes on a temporary spawn OBS instance. These instances are filled with data based on the dev:development_testdata rake task. This commit adds some buildable source to the package, which ensures that any spawn review app has some built binaries that we can use for testing.
Align dropdown menu to the right
The test was stubbing the auto_accept call and veryfied the method call afterwards. That is not a problem in itself, but doing so required a couple of additional stubs to pass along the 'request' we were testing. Because of that the test was relying to much on internals of the tested code. Removing the stubs makes the test more flexible of changes in the auto accept functionality and ensures that the full auto accept workflow is tested.
This adds a test that ensures the requests created by users with insufficient permissions are not getting auto accepted, but revoked.
This ensures that the new page was loaded before doing further tests.
…ight_kampff-1.1.3 [src/api] Update voight_kampff: 1.1.2 → 1.1.3 (patch)
…_to_review_app Add a buildable package to our review app setup
…accept_test Remove stubs from auto accept test
Fix flickering package feature test
…nitest-reporters-1.3.5 [src/api] Update minitest-reporters: 1.3.4 → 1.3.5 (patch)
Duplicated code added by mistake is removed from the layout.
We have a couple of places were we set the white-space attribute to 'pre-wrap' to format our text boxes nicely. This commit adds a CSS class for this to reduce the repetition of code.
Remove duplicated code related to CodeMirror
for add file view. Because this is what we decided in the pattern library so we need to change it to follow.
Before we would render long commit messages in one line, which means that at a certain length users would have to use a horizontal scrollbar. Fixes openSUSE#5954
[webui] Fix checkboxes for supersedeing requests in package view
Most modern browser don't allow JS to access the full path of the file and show e.g. C:\fakepath. As this is confusing for our users, we only show the filename and strip the path instead.
Before we had the issue that happened when responsiveness of datatables was happening either by long names of files or whenever the user resizes the page down until it hides some of the columns
Fix issue 5954
When nil is passed as the text it fails
The files view of the overview page for a package was having problems of responsiveness when filenames were too long. Co-authored-by: David Kang <dkang@suse.com>
…e_dialog_not_showing Fix issue about not showing dialogs on bootstrap datatables
…nput Use custom file input bootstrap class
Remove `}` leftover
…long_file_names Fix responsiveness of datatables when long file names
Fix helper force_utf8_and_transform_nonprintables
Convert the tables for users and groups to be responsive. Confirmation boxes are now modal dialogs.
Before we were navigating to another page for showing a simple form that could be in a dialog.
Before was using BRs and Ps for making space between the form elements and it was wrong, we now use form-group divs and works like a charm. Also use the homogeneous way of cancelling the dialog using a button on the bottom of the modal dialog
Before we had buttons for canceling a dialog that converted it in the default action to take when hitting enter inside an input field. Now we replaced the buttons with anchors styled properly, that way the default action is to submit the dialog instead of canceling.
Update bootstrap-master
…master Revert "Update bootstrap-master"
…8-bootstrap-master Revert "Revert "Update bootstrap-master""
for add file view. Because this is what we decided in the pattern library so we need to change it to follow.
Convert the tables for users and groups to be responsive. Confirmation boxes are now modal dialogs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.