Do not run InfluxDB backend subscriber in background #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBr
force-pushed
the
influx-flaky-test
branch
2 times, most recently
from
2c551e2
to
98a7b0c
Compare
It is not necessary as the influxdb gem already does this. This will also fix a flaky spec.
ChrisBr
force-pushed
the
influx-flaky-test
branch
from
98a7b0c
to
0b08a29
Compare
Codecov Report
@@ Coverage Diff @@
## master #6551 +/- ##
==========================================
+ Coverage 90.85% 90.85% +<.01%
==========================================
Files 448 448
Lines 19891 19887 -4
==========================================
- Hits 18071 18068 -3
+ Misses 1820 1819 -1 |
Codecov Report
@@ Coverage Diff @@
## master #6551 +/- ##
==========================================
+ Coverage 90.84% 90.84% +<.01%
==========================================
Files 448 448
Lines 19891 19887 -4
==========================================
- Hits 18069 18067 -2
+ Misses 1822 1820 -2 |
hennevogel
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary as the influxdb gem already does this. This will also fix a flaky spec.