Migrate project index page to bootstrap #6648
Conversation
saraycp
added
Frontend
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
+ Coverage 90.62% 90.63% +<.01%
==========================================
Files 469 467 -2
Lines 20434 20433 -1
==========================================
+ Hits 18519 18520 +1
+ Misses 1915 1913 -2 |
saraycp
force-pushed
the
bootstrap_project_index
branch
from
72cf5e2
to
b18a469
Compare
|
Within the production data seems to be a home project (excluding homes looks fine, you get a 2 columned table) that breaks the layout. That problem is also visible on https://build.opensuse.org/project?show_all=true, so just FYI.
|
| - @important_projects.each do |project| | ||
| %tr | ||
| %td | ||
| = link_to(project[0], action: :show, project: project[0]) |
| %td | ||
| = link_to(project[0], action: :show, project: project[0]) | ||
| %td | ||
| #{project[1]} |
saraycp
force-pushed
the
bootstrap_project_index
branch
from
b18a469
to
76a6f15
Compare
@coolo, it is fixed now. When we have long names and titles it breaks the line:
@dmarcoux please read my comments and let me know if you agree. |
Because? |
The content of the public projects' table is added by javascript. We keep it like it was with small changes only: the table itself is written by the view not by JS, we add "Search" placeholder and remove some unnecessary params. Co-authored-by: David Kang <dkang@suse.com>
saraycp
force-pushed
the
bootstrap_project_index
branch
from
76a6f15
to
f91efc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
+ Coverage 90.63% 90.63% +<.01%
==========================================
Files 472 467 -5
Lines 20441 20433 -8
==========================================
- Hits 18526 18520 -6
+ Misses 1915 1913 -2 |
Because server side pagination is out of scope for the bootstrap migration :) |
That is not true, if you can avoid migrating this 'pattern' to the new UI. The first "rule" we have for the migration scope is: Identify bad code patterns in the OLD UI and refactor them |
The content of the public projects' table is added by javascript. We keep it like
it was with small changes only: the table itself is written by the view not by JS,
we add "Search" placeholder and remove some unnecessary params.
Co-authored-by: David Kang dkang@suse.com
Before:
After: