Fix disappearing tabs on page zoom #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcoux
added
Frontend
|
Review app will appear here: http://obs-reviewlab.opensuse.org/dmarcoux-fix-tabs-on-zoom |
Codecov Report
@@ Coverage Diff @@
## master #6649 +/- ##
==========================================
+ Coverage 90.62% 90.63% +<.01%
==========================================
Files 469 469
Lines 20434 20434
==========================================
+ Hits 18519 18521 +2
+ Misses 1915 1913 -2 |
Codecov Report
@@ Coverage Diff @@
## master #6649 +/- ##
==========================================
- Coverage 90.66% 90.63% -0.03%
==========================================
Files 472 469 -3
Lines 20424 20434 +10
==========================================
+ Hits 18517 18521 +4
- Misses 1907 1913 +6 |
coolo
reviewed
Dec 17, 2018
On Firefox, there is a 1 pixel difference on some page zoom levels (130% and up) between an element's offset height/width and scroll height/width. This causes the tabs to shrink when they should not. Fixes #6597
coolo
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox, there is a 1 pixel difference on some page zoom levels (130% and up) between an element's offset height/width and scroll height/width. This causes the tabs to shrink when they should not.
Fixes #6597