Display user email on user#show view only to logged-in users #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcoux
added
Frontend
hennevogel
approved these changes
Jun 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #7753 +/- ##
==========================================
- Coverage 90.76% 90.73% -0.04%
==========================================
Files 500 500
Lines 21369 21369
==========================================
- Hits 19396 19389 -7
- Misses 1973 1980 +7 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #7753 +/- ##
==========================================
- Coverage 90.76% 90.73% -0.04%
==========================================
Files 500 500
Lines 21369 21369
==========================================
- Hits 19396 19389 -7
- Misses 1973 1980 +7 |
coolo
reviewed
Jun 13, 2019
| @@ -11,7 +11,7 @@ | |||
| %span.badge.badge-secondary.align-top | |||
| = title.upcase | |||
|
|
|||
| - unless user.is_nobody? | |||
| - unless User.possibly_nobody.is_nobody? | |||
There was a problem hiding this comment.
that's very long for if User.session
coolo
added a commit
to coolo/open-build-service
that referenced
this pull request
Jun 14, 2019
Followup on openSUSE#7753
coolo
added a commit
to coolo/open-build-service
that referenced
this pull request
Jun 14, 2019
Followup on openSUSE#7753
DavidKang
pushed a commit
to DavidKang/open-build-service
that referenced
this pull request
Jun 17, 2019
Followup on openSUSE#7753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7744
This is testable locally:
return trueas the first line in switch_to_webui2?