bs_publish: move out repository create stuff into separate function

[rhabacker]

This refactoring provides the counterpart of deleterepo() to increase code readability.

see #7679

Please note that this is my first obs post in Perl and I am not 100% sure if I have always used the correct Perl syntax.

[adrianschroeter]

you don't create repo metadata anymore, if no stage server is defined?
This is not wanted....

[rhabacker]

Because $stageservers is unused here I assume that you are suggesting to use BSUrlmapper::get_extrep($prp) instead, as done in the updated patch ?

[mlschroe]

Hey, where's the xrepoid handling? You can't simply delete such things...

[mlschroe]

Oh, wait, it's there. The inline comments confused me.

[mlschroe]

Please put $extrep in the data hash instead of calculating it again.

[mlschroe]

And your createrepo is actually not the counterpart of deleterepo, the counterpart of deleterepo is in fact the publish function. Your createrepo is more like a createmetadata function.

[rhabacker]

And your createrepo is actually not the counterpart of deleterepo, the counterpart of deleterepo is in fact the publish function. Your createrepo is more like a createmetadata function.

There is a set of createrepo_xxx() and deleterepo_xxx() function called by this new function. Does this mean that these functions are also only creating meta data and should be renamed to createmetadata_xxx and deletemetadata_xxx ?

[rhabacker]

Furthermore there are

   createpatterns_ymp($extrep, $projid, $xrepoid, $data, $patterntype{'ymp'});
   deletepatterns_ymp($extrep, $projid, $xrepoid, $data);

inside these functions. Does your statement apply also to this ?