Typography user show #8140
Merged
Typography user show #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We applied some changes regarding the contrast in the username. Apart from that, we grouped the email with the other elements at the bottom.
dmarcoux
reviewed
Aug 21, 2019
hennevogel
requested changes
Aug 21, 2019
|
@hennevogel @dmarcoux @DavidKang An alternative for the user's info area could be:
I simplified the beta stuff using only one switch instead of a link and a badget. I added a new commit that can be squashed after review. |
hennevogel
requested changes
Aug 21, 2019
DavidKang
force-pushed
the
typography-user-show
branch
from
e213a49
to
72792e7
Compare
|
@hennevogel, what about this approach, regarding the "beta program" |
|
@DavidKang awesome |
DavidKang
force-pushed
the
typography-user-show
branch
3 times, most recently
from
56bd7b5
to
5a39f08
Compare
hennevogel
added
the
review-app
|
Review app will appear here: http://obs-reviewlab.opensuse.org/davidkang-typography-user-show |
hennevogel
requested changes
Aug 23, 2019
saraycp
force-pushed
the
typography-user-show
branch
3 times, most recently
from
fe8597b
to
1e3ddd1
Compare
hennevogel
previously requested changes
Aug 26, 2019
| = check_box_tag('user[in_beta]', !user.in_beta, user.in_beta, class: 'custom-control-input', id: 'beta-switch') | ||
| = label_tag 'Public Beta Program', nil, class: 'custom-control-label', for: 'beta-switch' | ||
| = hidden_field_tag('user[login]', user.login) | ||
| %i.fa.fa-question-circle.text-info{ data: { placement: 'top', toggle: 'popover', html: 'true', |
There was a problem hiding this comment.
Suggested change
| %i.fa.fa-question-circle.text-info{ data: { placement: 'top', toggle: 'popover', html: 'true', | |
| %i.fa.fa-question-circle.text-info{ data: { placement: 'top', toggle: 'popover', html: 'true', | |
| content: 'In our <strong>beta program</strong> you can try ' + | |
| 'the latest features we develop, so you can give us feedback before we release them.' } } |
Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Lukas Krause <lkrause@suse.de>
saraycp
force-pushed
the
typography-user-show
branch
from
1e3ddd1
to
ea59658
Compare
saraycp
dismissed
hennevogel’s stale review
It was approved except for the text, which is already updated
saraycp
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We applied some changes regarding the contrast in the username. Apart from that, we grouped the email with the other elements at the bottom.
Before
After
Beta Program Tooltip:
