[2.10 backport] Make editor big where needed #8590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the editor textarea gets maximized most of the times, that is what users want. Don't show always the bottom box. We prefer to see more from the editor textarea. Co-authored-by: Eduardo Navarro <enavarro@suse.com> (cherry picked from commit eb30e4a)
Codecov Report
@@ Coverage Diff @@
## 2.10 #8590 +/- ##
==========================================
+ Coverage 90.68% 90.77% +0.08%
==========================================
Files 501 501
Lines 21381 21381
==========================================
+ Hits 19389 19408 +19
+ Misses 1992 1973 -19 |
hennevogel
approved these changes
Oct 17, 2019
eduardoj
approved these changes
Oct 18, 2019
|
The hakiri issue has been dealt with in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the editor textarea gets maximized most of the times, that is what users want.
Don't show always the bottom box. We prefer to see more from the editor textarea.
Originally authored by @hellcp and @eduardoj
Backported from #7958.
(cherry picked from commit eb30e4a)