Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request number by package name in excluded requests #8676

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Nov 7, 2019

In both webui and API, excluded requests list shows the package name, before there was only the request number.

Fixes: #8524

How to test?

osc api -X GET '/staging/<project>/excluded_requests'

or in webui

/staging_workflows/<staging_workflow_id>/excluded_requests

@saraycp saraycp added Frontend Things related to the OBS RoR app staging-workflow Things related to the staging workflow feature labels Nov 7, 2019
In both webui and API, excluded requests list shows the package name, not
only requets number.
@saraycp saraycp force-pushed the fix_8524_excluded_requests_package branch from c840247 to 6eb8038 Compare November 7, 2019 23:12
@coolo
Copy link
Member

coolo commented Nov 8, 2019

You're still required to enter a number to add excludes in the webui, but it's to be seen how often people actually use this. So far we relied purely on the command line for this, so displaying it properly is more important.

@coolo coolo merged commit 556ed5a into openSUSE:master Nov 8, 2019
@saraycp saraycp deleted the fix_8524_excluded_requests_package branch November 8, 2019 09:29
@saraycp
Copy link
Contributor Author

saraycp commented Nov 8, 2019

You're still required to enter a number to add excludes in the webui, but it's to be seen how often people actually use this. So far we relied purely on the command line for this, so displaying it properly is more important.

@coolo, I opened this issue so we don't forget it: #8677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app staging-workflow Things related to the staging workflow feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excluded requests should be shown as package names
2 participants