Re-organize staging projects XML results #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "requests_to_review" group has been removed, it contains redundant data. Untracked requests, obsolete requests and missing reviews have been moved from "status" scope to "requests" scope. So they are shown when retrieving staging projects via API with 'requests=1' and not with 'status=1'. Related tests and API doc has been updated.
saraycp
added
Frontend
After a short discussion with @coolo about this, it seems also a good idea to re-organize the webui view. Untracked requests, obsolete requests and missing reviews shouldn't be part of the Status section. I opened an issue for this: #8688 |
vpereira
approved these changes
Nov 8, 2019
|
CI is green but somehow misreported: https://circleci.com/workflow-run/4759b77e-80e7-4047-ad92-046553dd9271 |
dmarcoux
reviewed
Nov 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "requests_to_review" group has been removed, it contains redundant data.
Untracked requests, obsolete requests and missing reviews have been moved from "status" scope to "requests" scope. So they are shown when retrieving staging projects via API with 'requests=1' and not with 'status=1'.
Related tests and API doc has been updated.
Fixes: #8684
How to test?