Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs_worker: Allow passing --network to build process #9290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KyleFromKitware
Copy link
Contributor

This will configure bs_worker to allow network access inside the
build.

Please note that this is contingent on openSUSE/obs-build#555.

This will configure bs_worker to allow network access inside the
build.
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #9290 (62a5c5f) into master (7abef4d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9290      +/-   ##
==========================================
+ Coverage   90.85%   90.88%   +0.02%     
==========================================
  Files         512      512              
  Lines       20677    20677              
==========================================
+ Hits        18787    18793       +6     
+ Misses       1890     1884       -6     

@DavidKang DavidKang added the Backend Things regarding the OBS backend label Apr 7, 2020
@damianatorrpm
Copy link

Is there a repo on OBS that already build this?
I want to test it.

@adrianschroeter
Copy link
Member

adrianschroeter commented Aug 28, 2020 via email

@damianatorrpm
Copy link

On Freitag, 28. August 2020, 13:45:39 CEST Damian Ivanov wrote: Is there a repo on OBS that already build this? I want to test it.
we won't merge it that way. And we will definitive not enable it at all on build.opensuse.org ....

-- Adrian Schroeter adrian@suse.de Build Infrastructure Project Manager SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany (HRB 247165, AG München), Geschäftsführer: Felix Imendörffer

I understand though not what I meant, I meant like zypper ar obs://patched_obs_network/ && zypper dup
If that doesn't exist yet would the patch already work?

@KyleFromKitware
Copy link
Contributor Author

I've been using the patch on my private OBS installation for a while and it seems to work alright.

@adrianschroeter,

we won't merge it that way.

Do you mean this will not be merged, and that the PR should be closed? I did make it configurable so that it has to be explicitly enabled.

@KyleFromKitware
Copy link
Contributor Author

I see that there was a merge conflict on openSUSE/obs-build#555. I just fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Things regarding the OBS backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants