Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup owner search #9964

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Speedup owner search #9964

wants to merge 7 commits into from

Conversation

adrianschroeter
Copy link
Member 

[api] speed up maintainer lookup

Using special backend route the owner search is taking 0.15 seconds instead of 8.5 seconds.

We are down from 15 seconds to 2 seconds in total. 1 second of that is python
startup and SSL handshake.

@adrianschroeter adrianschroeter force-pushed the speedup_owner_search branch 2 times, most recently from 80ac3ec to 70705d4 Compare July 29, 2020 14:58
@DavidKang DavidKang added Backend Things regarding the OBS backend Frontend Things related to the OBS RoR app labels Jul 31, 2020
@adrianschroeter adrianschroeter force-pushed the speedup_owner_search branch 2 times, most recently from 96cfc18 to 5bdd85a Compare August 12, 2020 07:12
@mschnitzer
Copy link
Member

mschnitzer commented Aug 12, 2020 •
edited

Thank you Adrian! I really appreciate when this gets merged!

@fcrozat
Copy link

fcrozat commented Aug 12, 2020

I'm not 100% sure it is related with this PR but since a few days on IBS, packages which were still returned with bugowner who left the company are no longer returned at all.

@marcus-h marcus-h mentioned this pull request Aug 12, 2020
Merged
@fcrozat fcrozat mentioned this pull request Aug 12, 2020
Open
@adrianschroeter adrianschroeter force-pushed the speedup_owner_search branch 3 times, most recently from 5d5743c to af67ace Compare August 14, 2020 11:15
@hennevogel
Copy link
Member

This breaks Webui::SearchController...

@adrianschroeter adrianschroeter force-pushed the speedup_owner_search branch 3 times, most recently from 55a3c38 to 7495f7d Compare September 1, 2020 11:16
@adrianschroeter adrianschroeter force-pushed the speedup_owner_search branch 6 times, most recently from b2b31c4 to 50714de Compare December 11, 2020 07:21
@github-actions github-actions bot added the Documentation 📖 Things regarding our documentation label Jan 12, 2022
@adrianschroeter adrianschroeter mentioned this pull request Mar 2, 2022
Open
@eduardoj
Copy link
Member

eduardoj commented Mar 3, 2022

I rebased on master.

eduardoj added a commit to eduardoj/open-build-service that referenced this pull request Mar 4, 2022
@eduardoj
Remove unused code related to webui_mode
ffa101f 
This was already done in openSUSE#12001, but was not part of the original pull
request openSUSE#9964.
@eduardoj
Copy link
Member

eduardoj commented Mar 4, 2022

Introducing the method for_package in the model OwnerSearch::Assignee will require the task of adapting and adding specs in the currently failing model tests.

adrianschroeter and others added 6 commits May 11, 2023 16:33
@adrianschroeter @hennevogel
[api] speed up maintainer lookup
4c91751 
Using special backend route taking 0.15 instead of 8.5 seconds.

We are down from 15 seconds to 2. 1 second of that is python
startup and SSL handshake
@mlschroe @hennevogel
[backend] add simple searching of published binaries
9ab22ac 
Supported filters are 'name' and 'project'. This is much faster
than the going through the XPath engine when multiple names
or projects are specified.

The API will use this in the owner search function, which needs
to be as fast as possible.
@adrianschroeter @hennevogel
[api] fix invalid error handling
cb54b81 
test case got adapted to prove the introduced breakage with some webui optimization
commit ada5ac1
@adrianschroeter @hennevogel
[api] support owner lookup based on package container name
4f41e2a 
Fixes situations where no binary is named like the container
name (in some multibuild situations).

Allows also faster lookups in best case.
@eduardoj @hennevogel
Adapt tests to new /published API endpoint
18e1605
@eduardoj @hennevogel
Remove unused code related to webui_mode
d29a775 
This was already done in openSUSE#12001, but was not part of the original pull
request openSUSE#9964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backend Things regarding the OBS backend Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@adrianschroeter @mschnitzer @fcrozat @hennevogel @eduardoj @DavidKang @mlschroe @bugfinder